bitinflow/localtunnel
1
0
Fork 0
mirror of https://github.com/bitinflow/localtunnel.git synced 2026-03-20 17:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix for RangeError stack size exceeded

Browse Source 
This error would happen when there was a problem connecting to the local
server. The local.on('error') handler should have been a 'once' handler
because we emit the error again if it isn't a CONNREFUSED. So in the
case of a CONNRESET, it would trigger an infinite loop since the error
was being emitted back onto the local variable. Instead we just close
the remote socket and let a new one takes its place.

fixes #36
This commit is contained in:
Roman Shtylman
2014-04-14 15:28:09 -04:00
parent 9487797e02
commit 509841104b
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
client.js
View File

@@ -87,13 +87,13 @@ TunnelCluster.prototype.open = function() {
}); });
function conn_local() { function conn_local() {
debug('connecting locally to %s:%d', local_host, local_port);
if (remote.destroyed) { if (remote.destroyed) {
debug('remote destroyed');
self.emit('dead'); self.emit('dead');
return; return;
} }
debug('connecting locally to %s:%d', local_host, local_port);
remote.pause(); remote.pause();
// connection to local http server // connection to local http server
@@ -103,19 +103,24 @@ TunnelCluster.prototype.open = function() {
}); });
function remote_close() { function remote_close() {
debug('remote close');
self.emit('dead'); self.emit('dead');
local.end(); local.end();
}; };
remote.once('close', remote_close); remote.once('close', remote_close);
local.on('error', function(err) { // TODO some languages have single threaded servers which makes opening up
// multiple local connections impossible. We need a smarter way to scale
// and adjust for such instances to avoid beating on the door of the server
local.once('error', function(err) {
debug('local error %s', err.message);
local.end(); local.end();
remote.removeListener('close', remote_close); remote.removeListener('close', remote_close);
if (err.code !== 'ECONNREFUSED') { if (err.code !== 'ECONNREFUSED') {
return local.emit('error', err); return remove.end();
} }
// retrying connection to local server // retrying connection to local server
@@ -146,8 +151,8 @@ TunnelCluster.prototype.open = function() {
// tunnel is considered open when remote connects // tunnel is considered open when remote connects
remote.once('connect', function() { remote.once('connect', function() {
self.emit('open', remote); self.emit('open', remote);
conn_local();
}); });
remote.once('connect', conn_local);
}; };
var Tunnel = function(opt) { var Tunnel = function(opt) {