bitinflow/server
1
0
Fork 0
mirror of https://github.com/bitinflow/server.git synced 2026-03-13 13:35:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow dash characters in subdomain.

Browse Source 
Thank you @zackslash via https://github.com/localtunnel/server/pull/47

Rebased to latest master.
This commit is contained in:
Roman Shtylman
2018-04-01 18:04:48 -07:00
parent b1c296a409
commit 37df802cc0
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server.js
View File

@@ -81,7 +81,7 @@ module.exports = function(opt) {
const req_id = parts[1]; const req_id = parts[1];
// limit requested hostnames to 63 characters // limit requested hostnames to 63 characters
if (! /^[a-z0-9]{4,63}$/.test(req_id)) { if (! /^(?:[a-z0-9][a-z0-9\-]{4,63}[a-z0-9]|[a-z0-9]{4,63})$/.test(req_id)) {
const msg = 'Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.'; const msg = 'Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.';
ctx.status = 403; ctx.status = 403;
ctx.body = { ctx.body = {

15
test/basic.js
View File

@@ -118,6 +118,21 @@ test('request specific domain', function(done) {
}); });
}); });
test('request domain with dash', function(done) {
var opt = {
host: 'http://localhost:' + lt_server_port,
subdomain: 'abcd-1234'
};
localtunnel(test._fake_port, opt, function(err, tunnel) {
assert.ifError(err);
var url = tunnel.url;
assert.ok(new RegExp('^http:\/\/.*localhost:' + lt_server_port + '$').test(url));
test._fake_url = url;
done(err);
});
});
test('request domain that is too long', function(done) { test('request domain that is too long', function(done) {
var opt = { var opt = {
host: 'http://localhost:' + lt_server_port, host: 'http://localhost:' + lt_server_port,