From 7923e80b084ff7c0d66838556260705699434ac6 Mon Sep 17 00:00:00 2001 From: Siddhartha Sahai Date: Tue, 17 Nov 2015 21:08:36 +0530 Subject: [PATCH] increased subdomain character limit to 63 --- server.js | 6 +++--- test/basic.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/server.js b/server.js index 528584e..4037c2f 100644 --- a/server.js +++ b/server.js @@ -217,9 +217,9 @@ module.exports = function(opt) { app.get('/:req_id', function(req, res, next) { var req_id = req.params.req_id; - // limit requested hostnames to 20 characters - if (! /^[a-z0-9]{4,20}$/.test(req_id)) { - var err = new Error('Invalid subdomain. Subdomains must be lowercase and between 4 and 20 alphanumeric characters.'); + // limit requested hostnames to 63 characters + if (! /^[a-z0-9]{4,63}$/.test(req_id)) { + var err = new Error('Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.'); err.statusCode = 403; return next(err); } diff --git a/test/basic.js b/test/basic.js index b9e55ea..5e81ec5 100644 --- a/test/basic.js +++ b/test/basic.js @@ -121,12 +121,12 @@ test('request specific domain', function(done) { test('request domain that is too long', function(done) { var opt = { host: 'http://localhost:' + lt_server_port, - subdomain: 'thisdomainisoutsidethesizeofwhatweallow' + subdomain: 'thisdomainisoutsidethesizeofwhatweallowwhichissixtythreecharacters' }; localtunnel(test._fake_port, opt, function(err, tunnel) { assert(err); - assert.equal(err.message, 'Invalid subdomain. Subdomains must be lowercase and between 4 and 20 alphanumeric characters.'); + assert.equal(err.message, 'Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.'); done(); }); }); @@ -139,7 +139,7 @@ test('request uppercase domain', function(done) { localtunnel(test._fake_port, opt, function(err, tunnel) { assert(err); - assert.equal(err.message, 'Invalid subdomain. Subdomains must be lowercase and between 4 and 20 alphanumeric characters.'); + assert.equal(err.message, 'Invalid subdomain. Subdomains must be lowercase and between 4 and 63 alphanumeric characters.'); done(); }); });