1.1.1

Merge pull request #38 from LinusU/patch-1
re-throw client errors from bin/lt to let node handle it
2026-03-13 21:45:54 +00:00 · 2014-04-15 09:33:34 -04:00 · 2014-04-14 19:27:56 -04:00 · 2014-04-14 15:36:42 -04:00 · 2014-04-14 21:15:11 +02:00
3 changed files with 13 additions and 9 deletions
--- a/bin/client
+++ b/bin/client
@@ -27,14 +27,13 @@ var opt = {

 lt_client(opt.port, opt, function(err, tunnel) {
    if (err) {
-        console.error(err);
-        return process.exit(1);
+        throw err;
    }

    console.log('your url is: %s', tunnel.url);

    tunnel.on('error', function(err) {
-        console.error(err);
+        throw err;
    });
 });

--- a/client.js
+++ b/client.js
@@ -87,13 +87,13 @@ TunnelCluster.prototype.open = function() {
    });

    function conn_local() {
-        debug('connecting locally to %s:%d', local_host, local_port);
-
        if (remote.destroyed) {
+            debug('remote destroyed');
            self.emit('dead');
            return;
        }

+        debug('connecting locally to %s:%d', local_host, local_port);
        remote.pause();

        // connection to local http server
@@ -103,19 +103,24 @@ TunnelCluster.prototype.open = function() {
        });

        function remote_close() {
+            debug('remote close');
            self.emit('dead');
            local.end();
        };

        remote.once('close', remote_close);

-        local.on('error', function(err) {
+        // TODO some languages have single threaded servers which makes opening up
+        // multiple local connections impossible. We need a smarter way to scale
+        // and adjust for such instances to avoid beating on the door of the server
+        local.once('error', function(err) {
+            debug('local error %s', err.message);
            local.end();

            remote.removeListener('close', remote_close);

            if (err.code !== 'ECONNREFUSED') {
-                return local.emit('error', err);
+                return remove.end();
            }

            // retrying connection to local server
@@ -146,8 +151,8 @@ TunnelCluster.prototype.open = function() {
    // tunnel is considered open when remote connects
    remote.once('connect', function() {
        self.emit('open', remote);
+        conn_local();
    });
-    remote.once('connect', conn_local);
 };

 var Tunnel = function(opt) {
--- a/package.json
+++ b/package.json
@@ -2,7 +2,7 @@
  "author": "Roman Shtylman <shtylman@gmail.com>",
  "name": "localtunnel",
  "description": "expose localhost to the world",
-  "version": "1.1.0",
+  "version": "1.1.1",
  "repository": {
    "type": "git",
    "url": "git://github.com/shtylman/localtunnel.git"
Author	SHA1	Message	Date
Roman Shtylman	afbdc3697e	1.1.1	2014-04-15 09:33:34 -04:00
Roman Shtylman	0049f21b55	Merge pull request #38 from LinusU/patch-1 re-throw client errors from bin/lt to let node handle it	2014-04-14 19:27:56 -04:00
Roman Shtylman	509841104b	fix for RangeError stack size exceeded This error would happen when there was a problem connecting to the local server. The local.on('error') handler should have been a 'once' handler because we emit the error again if it isn't a CONNREFUSED. So in the case of a CONNRESET, it would trigger an infinite loop since the error was being emitted back onto the local variable. Instead we just close the remote socket and let a new one takes its place. fixes #36	2014-04-14 15:36:42 -04:00
Linus Unnebäck	92caf2f204	lt: better error handling Let node handle the displaying of error and setting exit code.	2014-04-14 21:15:11 +02:00